Skip to content

Fix deprecated examples extension ( *.pde → *.ino) #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

neomilium
Copy link

@neomilium neomilium commented Mar 12, 2025

2 commits in this PR to clean the code:

  • Rename examples that use obsolete Arduino extension (ie. *.pde) to current one *.ino

  • Remove any #include that involves a Cpp file, header suffice

@ackPeng
Copy link

ackPeng commented Mar 17, 2025

@neomilium Thank you very much for your PR, but on my host, if I don't have #include<xxx.cpp>, I will get an error of undefined reference to `PN532_HSU::PN532_HSU

@neomilium
Copy link
Author

@ackPeng Which development environment do you use? PlatformIO, Ardunio IDE, other?

@ackPeng
Copy link

ackPeng commented Mar 18, 2025

@neomilium I am using Arduino IDE

@neomilium
Copy link
Author

I'll try with this IDE.

@neomilium
Copy link
Author

OK, I see why it causes this under Arduino IDE.
To fix it, we will need to rework the way user include the library, so its a bigger PR.
I will remove this commit and keep the examples extension fix.

@neomilium neomilium changed the title Code cleanup Fix deprecated examples extension ( *.pde → *.ino) Mar 18, 2025
@ackPeng
Copy link

ackPeng commented Mar 19, 2025

@neomilium Thank you very much for your contribution

@ackPeng ackPeng merged commit 7f9b58e into Seeed-Studio:arduino Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants