Fix NDEF dependency name #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency name was incorrectly set to `external-repo` ([following the platform.io example](https://docs.platformio.org/en/latest/manifests/library-json/fields/dependencies.html)) which results in the NDEF library being cloned into a folder called `external-repo`. It makes more sense to call it `NDEF`; not only to make its description clearer but also to prevent collisions.
MatthewJeffson
added
PN532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NDEF dependency name was incorrectly set to
external-repo(following the platform.io example) which results in the NDEF library being cloned into a folder calledexternal-repo.It makes more sense to call it
NDEF; not only to make its description clearer but also to prevent collisions.