Fix: incompatible criteria for most_recent_events_only#175
Draft
Fix: incompatible criteria for most_recent_events_only#175
most_recent_events_only#175Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered one more filter incompatibility. I had suspected this case existed (the title of #97 mentions it), but I think this is the first time I encountered it in practice. It happens when you want to fetch the most recent event that has beliefs before some datetime.
Unfortunately, this fix can be quite detrimental for speed. I advise to use this combination of filters only together with an event time window.