Merged
Conversation
- Updates required for uvloop >= 0.22.1, following deprecations in the python API regarding async loop policies. - Updates to pytest to run tests using async correctly - Updates to runtimes so that pytest doesn't load the same module (conftest.py) multiple times. This involves adding __init__.py files in intermediate directories to explicitly define python packages.
lc525
force-pushed
the
quickfix/uvloop
branch
from
84fb519 to
f5e024b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixing MLServer custom image builds (and future MLServer images) for uvloop >= 0.22.1.
This also positions MLServer to be resilient to all the async API changes coming into future python versions (3.14 - 3.16), mostly caused by the deprecation of the async loop policy APIs.
Notes for reviewer
mlserver/utils.pyandmlserver/parallel/worker.py. Everything else is related to necessary adjustments to testing