Skip to content

[py] Created Method to return Keys.CONTROL or Keys.COMMAND based on User OS #15026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

[py] Created Method to return Keys.CONTROL or Keys.COMMAND based on User OS #15026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
539d671
created ctrl_or_command() method for keys library
shbenzer Jan 4, 2025
e8772e6
tests are passing
shbenzer Jan 4, 2025
6ce6ef5
updated implementation to stay true to current
shbenzer Jan 4, 2025
2796b64
flip verbage
shbenzer Jan 5, 2025
77e8a04
flip verbage
shbenzer Jan 5, 2025
f8c94b5
Merge branch 'trunk' into ctrl-or-meta
shbenzer Jan 16, 2025
2c53b2b
Merge branch 'trunk' into ctrl-or-meta
VietND96 Jan 20, 2025
49a8848
linting
shbenzer Feb 10, 2025
f777960
uncommented lines in format.sh
shbenzer Feb 10, 2025
b179311
Merge branch 'trunk' into ctrl-or-meta
shbenzer Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions py/selenium/webdriver/common/keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
# under the License.
"""The Keys implementation."""

import sys


class Keys:
"""Set of special keys codes."""
Expand Down Expand Up @@ -88,3 +90,5 @@ class Keys:
META = "\ue03d"
COMMAND = "\ue03d"
ZENKAKU_HANKAKU = "\ue040"

COMMAND_OR_CONTROL = COMMAND if sys.platform == "darwin" else CONTROL
10 changes: 10 additions & 0 deletions py/test/selenium/webdriver/common/typing_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,3 +346,13 @@ def test_should_type_an_integer(driver, pages):
element = driver.find_element(by=By.ID, value="keyReporter")
element.send_keys(1234)
assert element.get_attribute("value") == "1234"


def test_should_type_ctrl_or_command_based_on_os(driver, pages):
pages.load("javascriptPage.html")
element = driver.find_element(by=By.ID, value="keyReporter")
element.send_keys(1234)
assert element.get_attribute("value") == "1234"
element.send_keys(Keys.COMMAND_OR_CONTROL + "a")
element.send_keys(Keys.BACKSPACE)
assert element.get_attribute("value") == ""
Loading