Skip to content

[rust] Publish Selenium Manager as native shared library #15368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Draft

[rust] Publish Selenium Manager as native shared library #15368

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c944e3
Build shared library
nvborisenko Mar 1, 2025
69e5405
Define cargo targets
nvborisenko Mar 2, 2025
775ab44
Added example of Log Callback
nvborisenko Mar 6, 2025
15559d0
Example how to free fn result
nvborisenko Mar 7, 2025
eb287c1
Verify memory leakage for log events
nvborisenko Mar 7, 2025
1205f52
Handle panic
nvborisenko Mar 7, 2025
5c06ba7
Intentional panic
nvborisenko Mar 7, 2025
6d4be86
Move extern function to ffi.rs
nvborisenko Mar 7, 2025
0bc4ab4
Simplify exporting of ffi module
nvborisenko Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion rust/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@crates//:defs.bzl", "all_crate_deps")
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rustfmt_config")
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_shared_library", "rust_test", "rustfmt_config")

rustfmt_config(
name = "enable-rustfmt",
Expand Down Expand Up @@ -96,6 +96,18 @@ rust_library(
deps = all_crate_deps(normal = True),
)

rust_shared_library(
# The name here is used as the crate name
name = "selenium_manager_shared",
srcs = glob(
["src/**/*.rs"],
exclude = ["main.rs"],
),
edition = "2021",
visibility = ["//rust:__subpackages__"],
deps = all_crate_deps(normal = True),
)

filegroup(
name = "selenium_manager_srcs",
srcs = [
Expand Down
2 changes: 1 addition & 1 deletion rust/Cargo.Bazel.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"checksum": "e68bc8d92875cfa0a3769e6e31b05c99d2669f20fda466dd415ef9dcbd361b7d",
"checksum": "04c2f1c8b7c0ac539b226b5da83b0b41311961e3c8b2fed1a3dfae76721fec9c",
"crates": {
"addr2line 0.21.0": {
"name": "addr2line",
Expand Down
7 changes: 7 additions & 0 deletions rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ description = """
Selenium Manager is a CLI tool that automatically manages the browser/driver infrastructure required by Selenium.
"""

[[bin]]
name = "selenium-manager"

[lib]
name = "selenium_manager"
crate-type = ["cdylib", "rlib"]

[dependencies]
clap = { version = "4.5.23", features = ["derive", "cargo"] }
log = "0.4.22"
Expand Down
2 changes: 2 additions & 0 deletions rust/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ load(
"//rust/private:rustfmt_wrapper.bzl",
_rust_binary = "rust_binary",
_rust_library = "rust_library",
_rust_shared_library = "rust_shared_library",
_rust_test = "rust_test",
_rust_test_suite = "rust_test_suite",
)

rust_binary = _rust_binary
rust_library = _rust_library
rust_shared_library = _rust_shared_library
rust_test = _rust_test
rust_test_suite = _rust_test_suite
rustfmt_config = _rustfmt_config
5 changes: 5 additions & 0 deletions rust/private/rustfmt_wrapper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ load(
"rustfmt_test",
_rust_binary = "rust_binary",
_rust_library = "rust_library",
_rust_shared_library = "rust_shared_library",
_rust_test = "rust_test",
_rust_test_suite = "rust_test_suite",
)
Expand All @@ -27,6 +28,10 @@ def rust_library(name, **kwargs):
_rust_library(name = name, **kwargs)
_wrap_with_fmt_test(name, kwargs.get("tags", []))

def rust_shared_library(name, **kwargs):
_rust_shared_library(name = name, **kwargs)
_wrap_with_fmt_test(name, kwargs.get("tags", []))

def rust_binary(name, **kwargs):
_rust_binary(name = name, **kwargs)
_wrap_with_fmt_test(name, kwargs.get("tags", []))
Expand Down
13 changes: 13 additions & 0 deletions rust/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,3 +1674,16 @@ fn get_index_version(full_version: &str, index: usize) -> Result<String, Error>
.ok_or(anyhow!(format!("Wrong version: {}", full_version)))?
.to_string())
}

// ----------------------------------------------------------
// Exported functions
// ----------------------------------------------------------

// this just an example how to expose function for external usage
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bonigarcia can you please help to implement this function in rust? This function should be equivalent of selenium-manager.exe --browser chrome --browser-version 130 --browser-path /some/path --proxy some_value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major change, so there should be a project consensus on this feature first. Personally, I am not sure about it. Are the other bindings (in addition to .Net) following this approach?

#[no_mangle]
pub extern "C" fn get_test() -> *mut std::os::raw::c_char {
let sm = get_manager_by_browser("chrome".to_string()).unwrap();

let dp = std::ffi::CString::new(sm.get_driver_path_in_cache().unwrap().display().to_string()).unwrap();
dp.into_raw() // Transfer ownership to C
}