-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Create browser module, added user context related methods #15371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…o rb_bidi_create_user_context
…o rb_bidi_create_user_context
User description
Motivation and Context
This PR is a continuation to add full support for the BiDi protocol for the ruby bindings
It adds the browser module and the following methods:
For more information here is the BiDi documentation: https://w3c.github.io/webdriver-bidi/#command-browser-createUserContext
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added a new
Browser
module to the BiDi implementation.Implemented user context management methods:
create_user_context
,get_user_contexts
, andremove_user_context
.Introduced integration tests for the
Browser
module's user context methods.Added type signatures for the
Browser
module in RBS.Changes walkthrough 📝
bidi.rb
Add autoload for Browser module
rb/lib/selenium/webdriver/bidi.rb
Browser
module.browser.rb
Add Browser class with user context methods
rb/lib/selenium/webdriver/bidi/browser.rb
Browser
class under the BiDi module.create_user_context
,get_user_contexts
, andremove_user_context
.browser.rbs
Add type signatures for Browser module
rb/sig/lib/selenium/webdriver/bidi/browser.rbs
Browser
class and its methods.browser_spec.rb
Add integration tests for Browser module
rb/spec/integration/selenium/webdriver/bidi/browser_spec.rb
create_user_context
,get_user_contexts
,and
remove_user_context
.