Skip to content

[py] Change links in package config #15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Apr 20, 2025

User description

💥 What does this PR do?

This PR adjusts the [project.urls] section of py/pyproject.toml used in packaging for the Python bindings. This makes it adhere better to packaging standards and will show better links on our PyPI project page: https://pypi.org/project/selenium

There are no functional changes in this PR.

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Documentation, Other


Description

  • Update [project.urls] to use well-known PyPI labels

  • Change documentation link to WebDriver docs page

  • Add homepage and download links for better PyPI metadata

  • Remove redundant or aliased repository/source links


Changes walkthrough 📝

Relevant files
Documentation
pyproject.toml
Update and standardize project URLs in package config       

py/pyproject.toml

  • Replaced old [project.urls] section with one using well-known PyPI
    labels
  • Updated documentation link to point to WebDriver docs
  • Added homepage and download links
  • Removed redundant or aliased repository/source links
  • +8/-7     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 20, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix download URL

    The download URL should point to a direct download location rather than the PyPI
    project page. Consider using a GitHub releases URL or another direct download
    source.

    py/pyproject.toml [37-43]

     [project.urls]
     homepage = "https://www.selenium.dev"
     source = "https://github.com/SeleniumHQ/selenium/tree/trunk/py"
    -download = "https://pypi.org/project/selenium"
    +download = "https://github.com/SeleniumHQ/selenium/releases"
     changelog = "https://github.com/SeleniumHQ/selenium/blob/trunk/py/CHANGES"
     documentation = "https://www.selenium.dev/documentation/webdriver"
     issues = "https://github.com/SeleniumHQ/selenium/issues"
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion correctly identifies that the download URL could be more helpful by pointing to a direct download location rather than the PyPI page. Using GitHub releases provides users with access to all versions, which is more useful for a download link.

    Low
    • Update

    @selenium-ci selenium-ci added the C-py Python Bindings label Apr 20, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants