Skip to content

[java][BiDi] enable Edge BiDi tests for network module #15661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

[java][BiDi] enable Edge BiDi tests for network module #15661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31c6b88
[java] enable Edge BiDi tests for network module
Delta456 Apr 23, 2025
fc77efd
Merge branch 'trunk' into edge_network_bidi_tests
Delta456 Apr 23, 2025
d7a2a12
Merge branch 'trunk' into edge_network_bidi_tests
Delta456 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,17 @@
package org.openqa.selenium.bidi.network;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;

import java.util.List;
import org.junit.jupiter.api.Test;
import org.openqa.selenium.bidi.module.Network;
import org.openqa.selenium.testing.JupiterTestBase;
import org.openqa.selenium.testing.NeedsFreshDriver;
import org.openqa.selenium.testing.NotYetImplemented;

class AddInterceptParametersTest extends JupiterTestBase {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddInterceptPhase() {
try (Network network = new Network(driver)) {
String intercept =
Expand All @@ -42,7 +39,6 @@ void canAddInterceptPhase() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddInterceptPhases() {
try (Network network = new Network(driver)) {
String intercept =
Expand All @@ -55,7 +51,6 @@ void canAddInterceptPhases() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddStringUrlPattern() {
try (Network network = new Network(driver)) {
String intercept =
Expand All @@ -68,7 +63,6 @@ void canAddStringUrlPattern() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddStringUrlPatterns() {
try (Network network = new Network(driver)) {
String intercept =
Expand All @@ -84,7 +78,6 @@ void canAddStringUrlPatterns() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddUrlPattern() {
try (Network network = new Network(driver)) {
UrlPattern pattern =
Expand All @@ -104,7 +97,6 @@ void canAddUrlPattern() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canAddUrlPatterns() {
try (Network network = new Network(driver)) {
UrlPattern pattern1 =
Expand Down
1 change: 1 addition & 0 deletions java/test/org/openqa/selenium/bidi/network/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ java_selenium_test_suite(
browsers = [
"firefox",
"chrome",
"edge",
],
tags = [
"selenium-remote",
Expand Down
1 change: 0 additions & 1 deletion java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ void canAddIntercept() {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canContinueRequest() throws InterruptedException {
try (Network network = new Network(driver)) {
String intercept =
Expand Down
4 changes: 0 additions & 4 deletions java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class NetworkEventsTest extends JupiterTestBase {

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canListenToBeforeRequestSentEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (Network network = new Network(driver)) {
Expand All @@ -60,7 +59,6 @@ void canListenToBeforeRequestSentEvent()

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canListenToResponseStartedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (Network network = new Network(driver)) {
Expand All @@ -83,7 +81,6 @@ void canListenToResponseStartedEvent()

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canListenToResponseCompletedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (Network network = new Network(driver)) {
Expand All @@ -106,7 +103,6 @@ void canListenToResponseCompletedEvent()

@Test
@NeedsFreshDriver
@NotYetImplemented(EDGE)
void canListenToResponseCompletedEventWithCookie()
throws ExecutionException, InterruptedException, TimeoutException {
try (Network network = new Network(driver)) {
Expand Down
Loading