Use configured searchFields in search 'get result' #6023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring the lookupFields is a core part of the search module configuration. `get result` was not respecting that and had the default hard-coded. As all it does is pass the value through to the `search object` method (where it is an optional argument), I simply removed the reference. Failing case: https://jsfiddle.net/15xd2e41/1/ Working case: https://jsfiddle.net/ozcwbcf3/1/
willstott101
changed the title
|
|
|
Thanks for the review! I don't see where
I'm not sure what I've missed, but I'd love to get this PR up to scratch if I can. If it is required internally then perhaps we could add a |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the
searchFieldsis a core part of the search module configuration.get resultwas not respecting that and had the default hard-coded. As all it does is pass the value through to thesearch objectmethod (where it is an optional argument), I simply removed the reference.Failing case: https://jsfiddle.net/15xd2e41/1/ (with 'name' in the source objects)
Working case: https://jsfiddle.net/ozcwbcf3/1/ (with the default 'title' in the source objects)