Skip to content

Fix support for SMW 7.x in SRFSlideShow::linkFurtherResults#1035

Merged
jaideraf merged 2 commits into
masterfrom
paladox-patch-2
May 3, 2026
Merged

Fix support for SMW 7.x in SRFSlideShow::linkFurtherResults#1035
jaideraf merged 2 commits into
masterfrom
paladox-patch-2

Conversation

@paladox

@paladox paladox commented May 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #1034

@paladox

paladox commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

@paladox paladox requested review from alistair3149 and jaideraf May 3, 2026 18:05
@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.91%. Comparing base (efd567d) to head (5677834).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
formats/carousel/Carousel.php 0.00% 1 Missing ⚠️
formats/slideshow/SRF_SlideShow.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1035   +/-   ##
=========================================
  Coverage     52.91%   52.91%           
  Complexity     2438     2438           
=========================================
  Files            81       81           
  Lines          9275     9275           
=========================================
  Hits           4908     4908           
  Misses         4367     4367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaideraf jaideraf merged commit d918d0d into master May 3, 2026
5 of 6 checks passed
@jaideraf jaideraf deleted the paladox-patch-2 branch May 3, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[slideshow] Fatal error: Declaration of SRFSlideShow::linkFurtherResults must be compatible with...

2 participants