[Filtered] compacted client payload, base-layer switcher, and GeoJSON overlays - #1133
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
============================================
+ Coverage 58.17% 58.36% +0.18%
- Complexity 2435 2468 +33
============================================
Files 127 129 +2
Lines 11743 11825 +82
Branches 473 473
============================================
+ Hits 6832 6902 +70
- Misses 4566 4578 +12
Partials 345 345 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to the filtered format:
{v, f, s}slots (formatted/sort values omitted when identical, value-less printouts asnull), coordinates single-sourced. DecodedsrfFilteredConfig−53% (3.57 → 1.68 MB on a 2,575-item page), page −37%, identical behavior. Gadgets readingsrfFilteredConfigmust adapt (release note included).map view layersparameter: multiple base layers with a Leaflet switcher. Names are leaflet-providers strings and/or custom layers defined by the Maps extension's new$egMapsLeafletLayerDefinitions(Maps 13.1+, Add egMapsLeafletLayerDefinitions setting for custom Leaflet layers ProfessionalWiki/Maps#921); without Maps, provider names still work and unknown names are skipped without breaking the map.map view geojsonparameter: a GeoJSON overlay from aGeoJson:page or URL, fetched through the Maps extension (SSRF-guarded), simplestyle styling and popups, toggleable via the layer switcher, unaffected by the client-side filtering. With Maps absent the parameter yields an i18n'd query error and the view renders normally.All three parts were independently pr-reviewed (report-only) with findings integrated: numeric layer names keep their configured order, malformed GeoJSON degrades to no-overlay instead of a blank map, value-filter radio DOM ids are page-unique, and GeoJSON point features use the explicitly-pathed marker icon.