Skip to content

[AMD] Upgrade GLM-5 SGLang mi35x image to 0.5.10#1014

Merged
cquil11 merged 2 commits intomainfrom
feat/upgrade-glm5-sglang-image-mi35x-to-0.5.10
Apr 8, 2026
Merged

[AMD] Upgrade GLM-5 SGLang mi35x image to 0.5.10#1014
cquil11 merged 2 commits intomainfrom
feat/upgrade-glm5-sglang-image-mi35x-to-0.5.10

Conversation

@aarnetalman
Copy link
Copy Markdown
Collaborator

This pull request updates the container image used for the glm5-fp8-mi355x-sglang configuration in the .github/configs/amd-master.yaml file. The new image version is likely to include important updates or fixes.

Configuration update:

  • Updated the image field for glm5-fp8-mi355x-sglang from rocm/sgl-dev:v0.5.8.post1-rocm720-mi35x-20260219 to lmsysorg/sglang:v0.5.10-rocm720-mi35x in .github/configs/amd-master.yaml

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

@chunfangamd
Copy link
Copy Markdown
Collaborator

chunfangamd commented Apr 8, 2026

@claude test-config --config-files .github/configs/amd-master.yaml --config-keys glm5-fp8-mi355x-sglang

Copy link
Copy Markdown
Collaborator

@chunfangamd chunfangamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cquil11 cquil11 merged commit 6f6a5fe into main Apr 8, 2026
69 of 81 checks passed
@cquil11 cquil11 deleted the feat/upgrade-glm5-sglang-image-mi35x-to-0.5.10 branch April 8, 2026 18:40
@cquil11 cquil11 restored the feat/upgrade-glm5-sglang-image-mi35x-to-0.5.10 branch April 8, 2026 18:59
cquil11 added a commit that referenced this pull request Apr 8, 2026
cquil11 added a commit that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants