Skip to content

Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130 #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klaud-Cold wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130 #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/configs/nvidia-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2228,7 +2228,7 @@ glm5-fp4-b200-sglang:
- { tp: 4, ep: 1, conc-start: 4, conc-end: 256 }

glm5-fp4-b200-sglang-mtp:
image: lmsysorg/sglang:v0.5.10.post1-cu130
image: lmsysorg/sglang:v0.5.11-cu130
model: nvidia/GLM-5-NVFP4
model-prefix: glm5
runner: b200
Expand Down
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2343,3 +2343,9 @@
description:
- "Add Qwen3.5-397B-A17B FP8 MI355X ATOM benchmark configs with and without MTP"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310

- config-keys:
- glm5-fp4-b200-sglang-mtp
description:
- "Update SGLang image from v0.5.10.post1-cu130 to v0.5.11-cu130"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX

Check warning on line 2351 in perf-changelog.yaml

View check run for this annotation

Claude / Claude Code Review

Placeholder pr-link pull/XXX in perf-changelog entry 

The new perf-changelog entry for `glm5-fp4-b200-sglang-mtp` has `pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX` — the placeholder was not replaced before opening the PR. Since this is PR #1328, the link should be `pull/1328` to match the format used by every other entry in this file.
Copy link
Copy Markdown
Contributor

@claude claude Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The new perf-changelog entry for glm5-fp4-b200-sglang-mtp has pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX — the placeholder was not replaced before opening the PR. Since this is PR #1328, the link should be pull/1328 to match the format used by every other entry in this file.

Extended reasoning...

The diff at perf-changelog.yaml line 2351 adds a new changelog entry whose pr-link field is https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. The XXX is clearly a literal placeholder string that was never substituted with the actual PR number.

Every other entry in perf-changelog.yaml references a concrete PR number — the four entries immediately above this one use 1304, 1305, 1308, and 1310 respectively. A link with XXX resolves to a non-existent GitHub URL and breaks the changelog's navigability.

Step-by-step proof:

  1. The PR metadata states this is PR Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130 #1328.
  2. The new entry at perf-changelog.yaml:2351 adds: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX.
  3. Visiting https://github.com/SemiAnalysisAI/InferenceX/pull/XXX does not resolve to a real PR (the path segment must be an integer).
  4. The neighboring entries at lines 2325, 2332, 2338, and 2345 follow the convention pull/<integer> (1304, 1305, 1308, 1310).
  5. Therefore the correct value here is pull/1328.

Impact: This is a documentation/metadata issue only — it doesn't affect runtime behavior. However, the changelog is a key navigation aid for tracing perf regressions back to the PR that introduced them, so a broken link defeats the file's purpose for this entry.

Fix: Replace pull/XXX with pull/1328 on line 2351.

Loading