Skip to content

Update gptoss-fp4-h200-vllm vLLM image to v0.20.2#1335

Merged
Oseltamivir merged 2 commits into
mainfrom
claude/issue-1154-gptoss-fp4-h200-vllm
May 13, 2026
Merged

Update gptoss-fp4-h200-vllm vLLM image to v0.20.2#1335
Oseltamivir merged 2 commits into
mainfrom
claude/issue-1154-gptoss-fp4-h200-vllm

Conversation

@Klaud-Cold
Copy link
Copy Markdown
Collaborator

Summary

  • Update gptoss-fp4-h200-vllm image from vllm/vllm-openai:v0.18.0 to vllm/vllm-openai:v0.20.2

Ref #1154

Generated with Claude Code

…-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread perf-changelog.yaml Outdated
- gptoss-fp4-h200-vllm
description:
- "Update vLLM image from v0.18.0 to v0.20.2"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The new perf-changelog entry at line 2351 uses a literal placeholder pull/XXX instead of the actual PR number. Replace XXX with 1335 before merge so the changelog points to a valid URL (#1335).

Extended reasoning...

What the bug is\n\nThe new entry appended to perf-changelog.yaml (line 2351) has:\n\nyaml\npr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX\n\n\nThe XXX is a literal placeholder string that was never substituted with the real PR number. This produces a broken URL — https://github.com/SemiAnalysisAI/InferenceX/pull/XXX is not a valid GitHub PR link and will 404 if anyone clicks it from the changelog.\n\nWhy this is wrong\n\nEvery other entry in perf-changelog.yaml uses a real numeric PR ID. The four entries immediately preceding the new one (lines 2325, 2332, 2338, 2345) reference /pull/1304, /pull/1305, /pull/1308, and /pull/1310 respectively. The convention is clear: each changelog entry links to the PR that introduced the change. Leaving XXX in place breaks that convention and the link.\n\nStep-by-step proof\n\n1. Open perf-changelog.yaml and scroll to the new entry at line 2347–2351.\n2. Observe line 2351: pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX.\n3. Compare with line 2345 (the previous entry): pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310.\n4. Visit https://github.com/SemiAnalysisAI/InferenceX/pull/XXX — GitHub returns 404 because XXX is not a numeric PR ID.\n5. The PR introducing this change is #1335, so the correct value is /pull/1335.\n\nImpact\n\nThis is a documentation-only issue; it does not affect runtime behavior or benchmarks. However, the perf-changelog is the canonical record connecting performance changes to the PRs that caused them, so a broken link defeats the purpose of the entry.\n\nHow to fix\n\nReplace XXX with 1335 on line 2351 of perf-changelog.yaml:\n\nyaml\npr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1335\n

@github-actions
Copy link
Copy Markdown
Contributor

@Oseltamivir
Copy link
Copy Markdown
Collaborator

Screenshot 2026-05-12 at 5 56 01 PM

@Oseltamivir Oseltamivir merged commit 29a0b95 into main May 13, 2026
3 of 4 checks passed
@Oseltamivir Oseltamivir deleted the claude/issue-1154-gptoss-fp4-h200-vllm branch May 13, 2026 18:24
@github-actions
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants