-
Notifications
You must be signed in to change notification settings - Fork 222
Download history database #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Serene-Arc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the PR. I've been meaning to go through and fix all the tests and start merging PRs again, but to be honest, I haven't been wanting to go through a bunch of porn to get all the scrapers working. Thanks for doing that for me.
This is mostly fine. I have made some notes, and if there are new options being added to the CLI, then they need to be added to the README as well.
| ), | ||
| ), | ||
| ), | ||
| (("https://www.erome.com/a/vqtPuLXh", (r"https://[a-z]\d+.erome.com/\d{3}/vqtPuLXh/KH2qBT99_480p.mp4",)),), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the comments, these are two different types of resource. The tests must be replaced with similar ones to make sure that they don't start failing for different types of web pages. You replaced a video with a video, but there needs to be an image album as well.
Description
This PR adds option to enable a sqlite database for all downloads using hash to avoid downloading the same file again.
It also fixes the latest oAuth issue with latest version of PRAW.
Changes
Existing Issues