ide+jakttest: Fix hover mislabeling#1619
Merged
Merged
Conversation
cg-jl
force-pushed
the
ext-fixups-pr
branch
2 times, most recently
from
July 26, 2025 21:18
c753f06 to
349a629
Compare
cg-jl
commented
Jul 26, 2025
| } else { | ||
| resolved_iterable_result_type = iterable_trait_implementation!.implemented_type_args[0] | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
diff got messy here. I:
- removed the comments above the rewrite
- turned rewritten statement from
ParsedStatement::BlockintoParsedBlock, so that it can be tagged as coming from for loop typecheck. - patched a couple of spans so that ide resolves correctly.
cg-jl
force-pushed
the
ext-fixups-pr
branch
5 times, most recently
from
July 27, 2025 19:04
aaa473a to
6b2b2ec
Compare
cg-jl
changed the title
cg-jl
changed the title
cg-jl
marked this pull request as ready for review
July 27, 2025 20:07
cg-jl
force-pushed
the
ext-fixups-pr
branch
2 times, most recently
from
July 27, 2025 20:13
7c97c7d to
ac70f66
Compare
alimpfard
reviewed
Jul 28, 2025
alimpfard
left a comment
alimpfard
left a comment
Member
There was a problem hiding this comment.
mostly lgtm, just a couple nits:
Previously it would point to something in the range expression (`in <expr>`)
This lets typechecker mark variables as invisible to IDE, e.g for variables that were generated through desugaring. Solves issues regarding hover for bindings declared in `is` and through tuple destructuring.
This lets us declare tests for hover results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a couple of bugs I'm seeing while using the extension. These ones are on hover:
Before:
After:
Images are from
typechecker::typecheck_inline_cpp.Before:
After:
codegen::codegen_structBefore:
After:
codegen::codegen_enumisexpression are also resolved to the temporaries created within.Maybe we want to flag variables as 'autogenerated'?
Before:
After:
codegen::codegen_enum_destroy_variantI guess I could use this opportunity to setup testing. It can be done with shell + jq & get more complex as we need it.