Skip to content

AK: Add an OptionalBase helper, and allow specializing Optional with dedicated empty values #25894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+440 −165
Open

AK: Add an OptionalBase helper, and allow specializing Optional with dedicated empty values #25894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e0f96d
Meta: Fix some shellcheck issues
Hendiadyoin1 Apr 18, 2025
44e5fe0
CI: Bump Ubuntu runner to 24.04
Hendiadyoin1 Apr 18, 2025
514608c
Meta+CI: Bump minimum compiler versions to support deducing-this
Hendiadyoin1 Apr 16, 2025
c710e48
AK: Make Badge constexpr movable
Hendiadyoin1 Apr 16, 2025
3433411
AK: Add an OptionalBase helper to ease specializing Optional<T>
Hendiadyoin1 Apr 16, 2025
a78bea6
AK: Move some Traits<T> specializations up
Hendiadyoin1 Apr 16, 2025
8440270
AK: Add an Optional overload for values with special empty values
Hendiadyoin1 Apr 16, 2025
1ef47fe
AK: Use the Optional special case for nonnull smart pointers
Hendiadyoin1 Apr 16, 2025
4d8dcfe
AK: Use a null value for Optional<(Fly)String>s empty value
Hendiadyoin1 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Meta/build-image-extlinux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC these don't fail in CI, but only in the pre-commit check, because we only pass the changed scripts to shellcheck, which doesn't include shell_include.sh.

So most (if not all) # shellcheck source=/dev/null we already have in master might be unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it failed CI without the one in this exact file you point out....

Copy link
Member

@spholz spholz Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I have no idea why it fails here then.
I'm 99% sure that the build-image-raspberry-pi.sh one only failed in the pre-commit hook.

. "${script_path}/shell_include.sh"

if [ "$(id -u)" != 0 ]; then
Expand All @@ -30,7 +31,7 @@ for dir in "/usr/lib/syslinux/bios" "/usr/lib/syslinux" "/usr/share/syslinux"; d
break
fi
done
if [ -z $syslinux_dir ]; then
if [ -z "$syslinux_dir" ]; then
echo "can't find syslinux directory"
exit 1
fi
Expand Down Expand Up @@ -96,7 +97,7 @@ mkdir -p mnt/boot/extlinux
extlinux --install mnt/boot/extlinux
cp "$extlinux_cfg" mnt/boot/extlinux/extlinux.conf
for module in mboot.c32 menu.c32 libutil.c32 libcom32.c32; do
cp $syslinux_dir/$module mnt/boot/extlinux/
cp "$syslinux_dir/$module" mnt/boot/extlinux/
done
dd bs=440 count=1 conv=notrunc if=$syslinux_dir/mbr.bin of="$dev"
dd bs=440 count=1 conv=notrunc if="$syslinux_dir/mbr.bin" of="$dev"
echo "done"
1 change: 1 addition & 0 deletions Meta/build-image-grub-uefi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
. "${script_path}/shell_include.sh"

if [ "$(id -u)" != 0 ]; then
Expand Down
1 change: 1 addition & 0 deletions Meta/build-image-grub.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
. "${script_path}/shell_include.sh"

if [ "$(id -u)" != 0 ]; then
Expand Down
1 change: 1 addition & 0 deletions Meta/build-image-limine.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
. "${script_path}/shell_include.sh"

if [ ! -d "limine" ]; then
Expand Down
1 change: 1 addition & 0 deletions Meta/build-image-raspberry-pi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
. "${script_path}/shell_include.sh"

DISK_SIZE=$(($(disk_usage "$SERENITY_SOURCE_DIR/Base") + $(disk_usage Root) + 512 + 300))
Expand Down
1 change: 1 addition & 0 deletions Meta/build-native-partition.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e

script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)

# shellcheck source=/dev/null
. "${script_path}/shell_include.sh"

cleanup() {
Expand Down