WebServer: Send HTML body with 301 redirects #26484
Open
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, directory redirects (e.g., requesting
/pathwithout a trailing slash) sent a301 Moved Permanentlyresponse consisting only of headers. This caused clients that expect a response body or connection closure (such ascurlor strict HTTP/1.0 clients) to hang indefinitely waiting for content.This patch adds a minimal HTML body to the 301 response, compliant with RFC 2616. This ensures clients can correctly detect the end of the message and close the connection immediately.
Testing:
Verified using
curlandproinside SerenityOS.mkdir /var/www/test_redirectcurl -v http://127.0.0.1:8000/test_redirectFixes the issue where 301 redirects served by the WebServer get stuck.