Userland: Prevent a BuggieBox container from being exposed to /sys#26625
Open
supercomputer7 wants to merge 1 commit intoSerenityOS:masterfrom
Open
Userland: Prevent a BuggieBox container from being exposed to /sys#26625supercomputer7 wants to merge 1 commit intoSerenityOS:masterfrom
supercomputer7 wants to merge 1 commit intoSerenityOS:masterfrom
Conversation
/sys has lots of interesting information that an ordinary program in a container session shouldn't really care about, such as possible major and minor numbers of potentially exposed device files, etc. It seems like we don't really need /sys at the moment, so there's no harmful impact by this change. The risk of keeping /sys is probably low anyway, because, for example, a jailed process can't open most device files, even if it "sees" them in /sys. However, as another line of defense, let's just not mount /sys in such environment, if possible.
supercomputer7
force-pushed
the
buggiebox-container-dont-mount-sysfs
branch
from
9f27604 to
fc0e166
Compare
github-actions
bot
added
the
👀 pr-needs-review
Member
|
The commit category should be "Base:". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #26609.
/sys has lots of interesting information that an ordinary program in a
container session shouldn't really care about, such as possible major
and minor numbers of potentially exposed device files, etc.
It seems like we don't really need /sys at the moment, so there's no
harmful impact by this change.
The risk of keeping /sys is probably low anyway, because, for example,
a jailed process can't open most device files, even if it "sees" them
in /sys.
However, as another line of defense, let's just not mount /sys in such
environment, if possible.