LibWeb: Merge pull requests from Ladybird - #27017
Open
jamierocks wants to merge 10 commits into
Open
Conversation
And here's the wild part: instead of cloning WPT tests, import the relevant WPT tests that this fixes into our own test suite. This works by adding a small Ladybird-specific callback in resources/testharnessreport.js (which is what that file is meant for!) Note that these run as text tests, and so they must signal the runner when they are done. Tests using the "usual" WPT harness should just work, but tests that do something more freestyle will need manual signaling if they are to be imported. I've also increased the test timeout here from 30 to 60 seconds, to accommodate the larger WPT-style tests. (cherry picked from commit ec0838b)
Also bump the test timeout when running ctest to 120 seconds, to accommodate the slow GCC CI. (cherry picked from commit be03002)
...when running in test mode. This cuts down on the time it takes to run the imported WPT tests, and you can still get the full error by opening tests in the browser. (cherry picked from commit 0ebdac0)
The existing rebaseline script is a bit limiting in that it can only rebaseline a single test at a time. When making sweeping changes, this patch will let us rebaseline any number of tests at once. (cherry picked from commit f56b33f)
This is superseded by the headless-browser --rebaseline flag. (cherry picked from commit d33a87c)
This is a mixin in the IDL, so let's treat it as a mixin in our code and let both SVGElement and MathMLElement reuse the implementations that we wrote for HTMLElement. (cherry picked from commit 5f84c2c)
(cherry picked from commit 8dcab69)
There are two FIXMEs remaining that depend on a functional PolicyContainer, which we ignore for now and always behave like a CSP is set. (cherry picked from commit 84fe8d6)
This closer matches the spec and is needed in the implementation of the innerText setter. (cherry picked from commit a1a740b)
(cherry picked from commit 653c8f2)
jamierocks
force-pushed
the
wpt-tests
branch
from
September 8, 2026 16:12
938fcd7 to
ff1b607
Compare
jamierocks
marked this pull request as ready for review
September 8, 2026 16:13
github-actions
Bot
added
the
馃憖 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the following pull requests from Ladybird:
The main objective with this PR is to pull in the mechanisms required for importing WPT tests, and is an offspring of my original #26978 pull request - which I will need to return to.
* One downside of this commit is it changes many tests that have not been cherry-picked into Serenity (yet). So those tests will need to be amended when merging those commits. Not completely sure how I feel about that - so open to feedback.