Fix the bug to enable the demo_mode #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this bunny.
(\(\
( -.-)
o_(")(")Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/ui_assistant.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
TLSDC
reviewed
Apr 24, 2025
TLSDC
previously approved these changes
Apr 24, 2025
TLSDC
approved these changes
Apr 24, 2025
|
Hi could you please merge it if it is approved, I don't have the credentials thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change is being made?
In ui_assistant.py: agent_args.flags.action.demo_mode -> agent_args.flags.action.action_set.demo_mode
Why are these changes being made?
the demo_mode flag is not being used in the right place to enable the cursor on screen
the demo_mode should be set in
bgym.HighLevelActionSetArgshowever the current code is setting it indp.ActionFlagsDescription by Korbit AI
What change is being made?
Modify the code to correctly set the
demo_modeflag by updating the attribute path toagent_args.flags.action.action_set.demo_mode.Why are these changes being made?
The change addresses a bug where the
demo_modeflag was not being set correctly due to an incorrect attribute path, ensuring that thedemo_modefunctions as intended within the application. This fix ensures the proper configuration of demo_mode which is critical for its expected operation.