Skip to content

Const correctness in DomainVision #4

@PeterBowman

Description

@PeterBowman

CommDepthImage::get_intrinsic should be const:

/**
* Get the intrinsic matrix of the color camera.
*/
inline const arma::mat get_intrinsic()
{
arma::mat m(4, 4);
for (size_t i = 0; i < 4; ++i)
{
for (size_t j = 0; j < 4; j++)
{
m(i, j) = idl_CommDepthImage.intrinsic_m[i*4 + j]; // _m is 1-dimension!
}
}
return m;
}

This lack of a const qualifier affects several other getters across the DomainVision namespace, as far as I can tell.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions