Implement validation for equivalent paths

Author: C0nquistadore

src/Dibix.Sdk/CodeGeneration/Validation/EndpointModelValidator.cs

@@ -1,5 +1,8 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
+using System.Text.RegularExpressions;
+using Dibix.Http;
 
 namespace Dibix.Sdk.CodeGeneration
 {
@@ -24,11 +27,33 @@ public bool Validate(CodeGenerationModel model)
                     if (!this.ValidateAction(action))
                         isValid = false;
                 }
+
+                var childRouteGroups = controller.Actions
+                                                 .Where(x => x.ChildRoute != null)
+                                                 .GroupBy(x => $"{x.Method}#{NormalizeChildRoute(x.ChildRoute)}");
+
+                foreach (IGrouping<string, ActionDefinition> childRouteGroup in childRouteGroups)
+                {
+                    if (childRouteGroup.Count() <= 1) 
+                        continue;
+
+                    foreach (ActionDefinition action in childRouteGroup)
+                    {
+                        string route = RouteBuilder.BuildRoute(model.AreaName, controller.Name, action.ChildRoute);
+                        this._logger.LogError($"Equivalent paths are not allowed: {action.Method.ToString().ToUpperInvariant()} {route}", action.ChildRoute.Source, action.ChildRoute.Line, action.ChildRoute.Column);
+                    }
+                }
             }
 
             return isValid;
         }
 
+        private static string NormalizeChildRoute(string childRoute)
+        {
+            string normalizedChildRoute = Regex.Replace(childRoute, @"\{[^\}]+\}", "");
+            return normalizedChildRoute;
+        }
+
         private bool ValidateAction(ActionDefinition action)
         {
             if (action.ChildRoute == null)

tests/Dibix.Sdk.Tests.Database/Endpoints/GenericEndpointWithErrors.json

@@ -25,6 +25,16 @@
           }
         }
       }
+    },
+    {
+      "method": "GET",
+      "target": "EmptyWithParams",
+      "childRoute": "ambiguous/child/route/{a}"
+    },
+    {
+      "method": "GET",
+      "target": "EmptyWithParams",
+      "childRoute": "ambiguous/child/route/{b}"
     }
   ]
 }

tests/Dibix.Sdk.Tests/CodeGeneration/CodeGenerationTaskTests.cs

@@ -518,7 +518,7 @@ public void Endpoints_OpenApi()
         }
 
         [TestMethod]
-        public void Endpoint_WithInvalidPropertySource_Error()
+        public void Endpoint_WithValidationErrors_Error()
         {
             this.ExecuteTestAndExpectError
             (
@@ -541,7 +541,9 @@ public void Endpoint_WithInvalidPropertySource_Error()
 Endpoints\GenericEndpointWithErrors.json(19,23,19,23):error:Property 'Nm' not found on contract 'Dibix.Sdk.Tests.DomainModel.Entry'
 Endpoints\GenericEndpointWithErrors.json(24,27,24,27):error:Property 'Nm' not found on contract 'Dibix.Sdk.Tests.DomainModel.Entry'
 Endpoints\GenericEndpointWithErrors.json(9,19,9,19):error:Source 'ENV' does not support property 'MachinePassword'
-Endpoints\GenericEndpointWithErrors.json(16,27,16,27):error:The path segment 'get' is a known HTTP verb, which should be indicated by the action method and is therefore redundant: this/get/is/wrong"
+Endpoints\GenericEndpointWithErrors.json(16,27,16,27):error:The path segment 'get' is a known HTTP verb, which should be indicated by the action method and is therefore redundant: this/get/is/wrong
+Endpoints\GenericEndpointWithErrors.json(32,22,32,22):error:Equivalent paths are not allowed: GET Tests/GenericEndpoint/ambiguous/child/route/{a}
+Endpoints\GenericEndpointWithErrors.json(37,22,37,22):error:Equivalent paths are not allowed: GET Tests/GenericEndpoint/ambiguous/child/route/{b}"
             );
         }