Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 102 additions & 1 deletion internal/server/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,27 @@ func (fakeNomadClient) GetJob(jobID string, query *api.QueryOptions) (*api.Job,
stable := true
stop := false
submitTime := int64(1)
return &api.Job{ID: &jobID, Name: &jobName, Namespace: &namespace, Type: &jobType, Priority: &priority, Version: &version, Stable: &stable, Stop: &stop, SubmitTime: &submitTime}, &api.QueryMeta{}, nil
tgName := "web"
return &api.Job{
ID: &jobID, Name: &jobName, Namespace: &namespace, Type: &jobType,
Priority: &priority, Version: &version, Stable: &stable, Stop: &stop, SubmitTime: &submitTime,
TaskGroups: []*api.TaskGroup{
{
Name: &tgName,
Networks: []*api.NetworkResource{
{
Mode: "bridge",
ReservedPorts: []api.Port{{Label: "http", Value: 80, To: 8080}},
DynamicPorts: []api.Port{{Label: "metrics", To: 9090}},
},
},
Tasks: []*api.Task{
{Name: "nginx", Driver: "docker", Config: map[string]interface{}{"image": "nginx:alpine"}},
{Name: "agent", Driver: "docker", Config: map[string]interface{}{"image": "consul:latest"}},
},
},
},
}, &api.QueryMeta{}, nil
}
func (fakeNomadClient) GetJobScaleStatus(jobID string, query *api.QueryOptions) (*api.JobScaleStatusResponse, *api.QueryMeta, error) {
return &api.JobScaleStatusResponse{JobID: jobID, Namespace: "default", TaskGroups: map[string]api.TaskGroupScaleStatus{"cache": {Desired: 1, Placed: 1, Running: 1, Healthy: 1, Unhealthy: 0}}}, &api.QueryMeta{}, nil
Expand Down Expand Up @@ -283,3 +303,84 @@ func TestListRegionsToolSchemaIncludesProperties(t *testing.T) {
}
must.Eq(t, "full Nomad job ID", jobIDProperty["description"])
}

func TestGetJobIncludesTaskGroupsWithNetworksAndTasks(t *testing.T) {
t.Parallel()

logger := slog.New(slog.NewTextHandler(io.Discard, nil))
server := New(fakeNomadClient{}, logger)
client := mcp.NewClient(&mcp.Implementation{Name: "test-client", Version: "0.0.1"}, nil)

clientTransport, serverTransport := mcp.NewInMemoryTransports()
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()

serverSession, err := server.Connect(ctx, serverTransport, nil)
must.NoError(t, err)
defer serverSession.Close()

clientSession, err := client.Connect(ctx, clientTransport, nil)
must.NoError(t, err)
defer clientSession.Close()

result, err := clientSession.CallTool(ctx, &mcp.CallToolParams{Name: "get_job", Arguments: map[string]any{"job_id": "example"}})
must.NoError(t, err)
must.False(t, result.IsError)

structured, ok := result.StructuredContent.(map[string]any)
must.True(t, ok)

job, ok := structured["job"].(map[string]any)
must.True(t, ok)

taskGroups, ok := job["task_groups"].([]any)
must.True(t, ok)
must.Len(t, 1, taskGroups)

tg, ok := taskGroups[0].(map[string]any)
must.True(t, ok)
must.Eq(t, "web", tg["name"])

networks, ok := tg["networks"].([]any)
must.True(t, ok)
must.Len(t, 1, networks)

network, ok := networks[0].(map[string]any)
must.True(t, ok)
must.Eq(t, "bridge", network["mode"])

reservedPorts, ok := network["reserved_ports"].([]any)
must.True(t, ok)
must.Len(t, 1, reservedPorts)

port, ok := reservedPorts[0].(map[string]any)
must.True(t, ok)
must.Eq(t, "http", port["label"])
must.Eq(t, float64(80), port["value"].(float64))
must.Eq(t, float64(8080), port["to"].(float64))

dynamicPorts, ok := network["dynamic_ports"].([]any)
must.True(t, ok)
must.Len(t, 1, dynamicPorts)

dynPort, ok := dynamicPorts[0].(map[string]any)
must.True(t, ok)
must.Eq(t, "metrics", dynPort["label"])
must.Eq(t, float64(9090), dynPort["to"].(float64))

tasks, ok := tg["tasks"].([]any)
must.True(t, ok)
must.Len(t, 2, tasks)

nginxTask, ok := tasks[0].(map[string]any)
must.True(t, ok)
must.Eq(t, "nginx", nginxTask["name"])
must.Eq(t, "docker", nginxTask["driver"])
must.Eq(t, "nginx:alpine", nginxTask["image"])

agentTask, ok := tasks[1].(map[string]any)
must.True(t, ok)
must.Eq(t, "agent", agentTask["name"])
must.Eq(t, "docker", agentTask["driver"])
must.Eq(t, "consul:latest", agentTask["image"])
}
60 changes: 60 additions & 0 deletions internal/tools/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,66 @@ func summarizeList(kind string, count int, queryMeta *api.QueryMeta) string {
return fmt.Sprintf("Returned %d %s.", count, kind)
}

func taskGroupsMap(groups []*api.TaskGroup) []map[string]any {
items := make([]map[string]any, 0, len(groups))
for _, tg := range groups {
if tg == nil {
continue
}
items = append(items, map[string]any{
"name": derefString(tg.Name),
"networks": networksMap(tg.Networks),
"tasks": tasksMap(tg.Tasks),
})
}
return items
}

func networksMap(networks []*api.NetworkResource) []map[string]any {
items := make([]map[string]any, 0, len(networks))
for _, n := range networks {
if n == nil {
continue
}
items = append(items, map[string]any{
"mode": n.Mode,
"reserved_ports": portsMap(n.ReservedPorts),
"dynamic_ports": portsMap(n.DynamicPorts),
})
}
return items
}

func portsMap(ports []api.Port) []map[string]any {
items := make([]map[string]any, 0, len(ports))
for _, p := range ports {
items = append(items, map[string]any{
"label": p.Label,
"value": p.Value,
"to": p.To,
})
}
return items
}

func tasksMap(tasks []*api.Task) []map[string]any {
items := make([]map[string]any, 0, len(tasks))
for _, t := range tasks {
if t == nil {
continue
}
item := map[string]any{
"name": t.Name,
"driver": t.Driver,
}
if image, ok := t.Config["image"]; ok {
item["image"] = image
}
items = append(items, item)
}
return items
}

func serviceRegistrationMap(service *api.ServiceRegistration) map[string]any {
if service == nil {
return map[string]any{}
Expand Down
1 change: 1 addition & 0 deletions internal/tools/jobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ func registerJobTools(server *mcp.Server, nomadClient client.Facade) {
"datacenters": job.Datacenters,
"meta": job.Meta,
"task_group_count": len(job.TaskGroups),
"task_groups": taskGroupsMap(job.TaskGroups),
},
"summary": map[string]any{
"job_id": summary.JobID,
Expand Down