Skip to content

Comments

Add position property to facets to make it easy to change the order in which they are rendered#58

Merged
loevgaard merged 1 commit intomasterfrom
position-to-facet
Feb 13, 2025
Merged

Add position property to facets to make it easy to change the order in which they are rendered#58
loevgaard merged 1 commit intomasterfrom
position-to-facet

Conversation

@loevgaard
Copy link
Member

Fixes #56

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.58%. Comparing base (78d8d2b) to head (66d0028).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Form/Builder/CheckboxFilterFormBuilder.php 0.00% 1 Missing ⚠️
src/Form/Builder/ChoiceFilterFormBuilder.php 0.00% 1 Missing ⚠️
src/Form/Builder/RangeFilterFormBuilder.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
- Coverage     34.59%   34.58%   -0.02%     
  Complexity      619      619              
============================================
  Files           119      119              
  Lines          2081     2085       +4     
============================================
+ Hits            720      721       +1     
- Misses         1361     1364       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard merged commit 90c6228 into master Feb 13, 2025
36 of 38 checks passed
@loevgaard loevgaard deleted the position-to-facet branch February 13, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request]: Be able to add position to facets

1 participant