Fix Both IndexEntity & RemoveEntity messages are handled

[SebLours]

Fix #66

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.33%. Comparing base (adecef0) to head (a7c27df).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
src/Message/Handler/AbstractEntityHandler.php	0.00%	2 Missing ⚠️
src/Message/Handler/IndexEntityHandler.php	0.00%	2 Missing ⚠️
src/Message/Handler/RemoveEntityHandler.php	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
- Coverage     33.36%   33.33%   -0.04%     
- Complexity      648      649       +1     
============================================
  Files           123      123              
  Lines          2161     2163       +2     
============================================
  Hits            721      721              
- Misses         1440     1442       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[loevgaard]

I propose to not have the __invoke method inside the abstract class and instead move that to the concrete class, so we don't need the handles attribute on the tag.

[SebLours]

Ok for this!

[loevgaard]

will you try and fix it or should I? :)

[SebLours]

I try to fix it today!

[loevgaard]

Great, thanks :D

[SebLours]

@loevgaard i add an invoke method in each handler.

I notice another issue (in the master branch) with \Setono\SyliusMeilisearchPlugin\EventListener\Doctrine\EntityListener during the post remove process. I'll have a look later.

[loevgaard]

Suggested change

	protected function handle(RemoveEntity|IndexEntity $message): void
	protected function handle(RemoveEntity|IndexEntity $message, callable $action): void

I think I would change the signature to this and add the callback in the concrete handler like:

$this->handle($message, fn(Index $index) => $index->indexer()->removeEntity($entity););

Wdyt?

[loevgaard]

Great work, @SebLours 🎉