Fix indexable deletion in EntityListener by SebLours · Pull Request #69 · Setono/sylius-meilisearch-plugin

SebLours · 2025-03-03T17:11:15Z

codecov · 2025-03-03T17:14:38Z

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (0d498fe) to head (dcbfc11).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
src/EventListener/Doctrine/EntityListener.php	0.00%	22 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     33.33%   33.07%   -0.26%     
- Complexity      649      655       +6     
============================================
  Files           123      123              
  Lines          2163     2180      +17     
============================================
  Hits            721      721              
- Misses         1442     1459      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/EventListener/Doctrine/EntityListener.php

loevgaard · 2025-03-05T10:53:33Z

src/EventListener/Doctrine/EntityListener.php

-        $this->dispatch($eventArgs, static fn (IndexableInterface $entity) => RemoveEntity::new($entity));
+        $this->dispatch(
+            $eventArgs,
+            fn (IndexableInterface $entity) => new RemoveEntity($entity::class, $this->removeIndexableStorage[$entity]),


I guess we need to check if this $this->removeIndexableStorage[$entity] exists first?

src/EventListener/Doctrine/EntityListener.php

loevgaard

Great work, once again @SebLours 🥇