Conversation
8c1a8b4 to
b8c7536
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
============================================
- Coverage 32.69% 32.63% -0.07%
- Complexity 660 668 +8
============================================
Files 124 127 +3
Lines 2205 2237 +32
============================================
+ Hits 721 730 +9
- Misses 1484 1507 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b8c7536 to
0f5b958
Compare
|
|
||
| interface CanonicalUrlGeneratorInterface | ||
| { | ||
| public function generate(Request $request, array $parameters = []): string; |
There was a problem hiding this comment.
What were your thoughts with the array $parameters = [] argument?
There was a problem hiding this comment.
It allows the user to customise the URL generation. For example, you could pass some query parameters you want to keep.
There was a problem hiding this comment.
One could decorate the generator, do some shenanigans with the query parameters to build a parameters array and pass it to the inner generator.
There was a problem hiding this comment.
I just added a test case for it.
4db2a75 to
7cdc1d3
Compare
7cdc1d3 to
af676a6
Compare
Fixes #73