Skip to content

Comments

Move the extraction of metadata to the factory and make the meta a value object instead#84

Merged
loevgaard merged 1 commit intomasterfrom
refactor-metadata
May 30, 2025
Merged

Move the extraction of metadata to the factory and make the meta a value object instead#84
loevgaard merged 1 commit intomasterfrom
refactor-metadata

Conversation

@loevgaard
Copy link
Member

No description provided.

@loevgaard loevgaard requested a review from vvasiloi May 13, 2025 12:57
@loevgaard loevgaard force-pushed the refactor-metadata branch 3 times, most recently from 4b4b396 to 0a707ef Compare May 13, 2025 13:14
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 32.22%. Comparing base (46c318c) to head (7cb8fcc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Document/Metadata/MetadataFactory.php 80.00% 12 Missing ⚠️
src/DataMapper/ImageDataMapper.php 0.00% 2 Missing ⚠️
src/Config/Index.php 0.00% 1 Missing ⚠️
src/DataMapper/Product/AttributesDataMapper.php 0.00% 1 Missing ⚠️
src/DataMapper/Product/OptionsDataMapper.php 0.00% 1 Missing ⚠️
.../Product/Setter/DocumentAttributesValuesSetter.php 0.00% 1 Missing ⚠️
...per/Product/Setter/DocumentOptionsValuesSetter.php 0.00% 1 Missing ⚠️
src/Form/Builder/SearchFormBuilder.php 0.00% 1 Missing ⚠️
src/Meilisearch/Query/MultiSearchBuilder.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     32.36%   32.22%   -0.14%     
+ Complexity      681      674       -7     
============================================
  Files           129      130       +1     
  Lines          2277     2265      -12     
============================================
- Hits            737      730       -7     
+ Misses         1540     1535       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loevgaard loevgaard force-pushed the refactor-metadata branch from 0a707ef to 7cb8fcc Compare May 13, 2025 13:18
@loevgaard loevgaard merged commit 75b9d32 into master May 30, 2025
37 of 38 checks passed
@loevgaard loevgaard deleted the refactor-metadata branch May 30, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants