Fluke/zotac zone dials

[flukejones]

No description provided.

[flukejones]

WIP. Needs help

[flukejones]

I'm at a loss as to why I'm getting a dual event:

[src/input/composite_device/mod.rs:329:25] &device_id = "evdev://event11"
[src/input/composite_device/mod.rs:329:25] &event = Native(
    NativeEvent {
        capability: Gamepad(
            Dial(
                RightStickDial,
            ),
        ),
        source_capability: None,
        value: Vector2 {
            x: Some(
                -1.0,
            ),
            y: None,
        },
    },
)
[src/input/event/value.rs:1009:17] direction.as_str() = "counter-clockwise"
[src/input/event/value.rs:1009:17] direction.as_str() = "clockwise"
[2025-04-19T10:53:53Z DEBUG inputplumber::input::composite_device] Checking single intercept event.
[2025-04-19T10:53:53Z DEBUG inputplumber::input::composite_device] Checking single intercept event.
[src/input/composite_device/mod.rs:329:25] &device_id = "evdev://event11"
[src/input/composite_device/mod.rs:329:25] &event = Native(
    NativeEvent {
        capability: Gamepad(
            Dial(
                RightStickDial,
            ),
        ),
        source_capability: None,
        value: Vector2 {
            x: Some(
                -1.0,
            ),
            y: None,
        },
    },
)
[src/input/event/value.rs:1009:17] direction.as_str() = "counter-clockwise"
[src/input/event/value.rs:1009:17] direction.as_str() = "clockwise"
[2025-04-19T10:53:53Z DEBUG inputplumber::input::composite_device] Checking single intercept event.
[2025-04-19T10:53:53Z DEBUG inputplumber::input::composite_device] Checking single intercept event.

Doesn't make sense at all. Kernel driver ouputs a single event.

[pastaq]

Are you mapping the evdev and the hidraw?

[pastaq]

You have the x axis of the dial mapped to two events, so it will trigger on both. You should translate the InputValue for that capability to clockwise/counterclockwise based on the axis value being > 0 / < 0 instead.

[flukejones]

@pastaq can you walk me through this please? There is just too much repetitive code for me to follow around here.

[flukejones]

Hmm no I think I understand now.

[flukejones]

Alright so everything works now except for this particular problem:

The driver emits and re-emits either 1 or -1. These events are seen fine for the raw event handling. But when it gets to event/value.rs translate() it falls over.

I'm not really all that sure how best to handle translate_dial_to_button(). What happens is that due to the above a release event is never seen, and when you turn the dial the opposite way we then get a 0 due to changed direction and value. If I change translate_dial_to_button() to:

return match direction.as_str() {
    "clockwise" => {
        if let Some(x) = x {
            if x > 0.0 {
                Ok(InputValue::Bool(true))
            } else {
                Ok(InputValue::None)
            }
        } else {
            Ok(InputValue::None)
        }
    }
    "counter-clockwise" => {
        if let Some(x) = x {
            if x < 0.0 {
                Ok(InputValue::Bool(true))
            } else {
                Ok(InputValue::None)
            }
        } else {
            Ok(InputValue::None)
        }
    }

I never get another event from IP on these. They are stuck on true. So i assume the values get cached? At the very least I think REL_WHEEL and such need to ignore that there is no 0 event.

[ShadowApex]

Looking at this more, since these events do not have a "button up" state, you'll need to emulate that yourself when encountering a dial -> button translation. It seems like what you want to do is send a "button down" + "button up" event for each "tick" of the dial. So we'll need to translate that single dial event into "button down" + "button up" events.

There may be a more elegant way to do this, but what first comes to mind is you could handle this in the translate_event() function in composite_device/mod.rs. In that function, you can check to see if this is a dial -> button translation and create the button up/down events to emit there.

E.g.

                // Translate the event into the defined target event(s)
                for target_event in mapping.target_events.iter() {
                    // TODO: We can cache this conversion for faster translation
                    let target_cap: Capability = target_event.clone().into();
                    let result = event.get_value().translate(
                        &source_cap,
                        &mapping.source_event,
                        &target_cap,
                        target_event,
                    );
                    let value = match result {
                        Ok(v) => v,
                        ...
                    };
                    if matches!(value, InputValue::None) {
                        continue;
                    }

                    // If the the event translation should result in a button pulse, return the
                    // translated pulse events.
                    if source_cap.is_button_pulse_translation(target_cap) {
                        let event = NativeEvent::new_translated(source_cap.clone(), target_cap, InputValue::Bool(true));
                        events.push(event);
                        let event = NativeEvent::new_translated(source_cap.clone(), target_cap, InputValue::Bool(false));
                        events.push(event);
                        continue;
                    }

                    let event = NativeEvent::new_translated(source_cap.clone(), target_cap, value);
                    events.push(event);
                }
  ...

[flukejones]

Alright, this is working now. So cleanup is required.

[flukejones]

Cleaned up extraneous formatting. Tested. Should be good to go pending review.

[pastaq]

Some minor comment cleanup, otherwise LGTM, thanks!

[ShadowApex]

Also some small suggestions in addition to @pastaq 's. Otherwise looks good!

[ShadowApex]

Looks good! Thanks!

[github-actions]

🎉 This PR is included in version 0.55.0 🎉

The release is available on:

• v0.55.0
• GitHub release

Your semantic-release bot 📦🚀