Fix for boiler effectivity #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, YAFC is great, thank you for sharing your work!
This PR is a fix for oil boilers (boilers that take fluid fuel) in pyanodons/pypetroleumhandling, which have an
effectivityvalue of 2, where YAFC seems to report around half the amount of steam that I get in-game.In the current code, effectivity is used to correctly scale down the amount of fuel these boilers consume, but when computing how long it takes to heat up the liquid/steam this effectivity is not taken into account. As a result, I think the recipe time is longer than it should be, which results in YAFC thinking steam is produced at a lower rate.
The change in this PR is to consider the effective energy from the fuel, and results in steam production numbers that seem to match those I get in-game.