Fork review for upstream #764: Vector update metadata and version checks#7
Fork review for upstream #764: Vector update metadata and version checks#7Shallow-dusty wants to merge 4 commits into
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 723c2f5c36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <string name="app_name" translatable="false">LSPosed</string> | ||
| <string name="install_url" translatable="false">https://github.com/JingMatrix/LSPosed#install</string> | ||
| <string name="latest_url" translatable="false">https://github.com/JingMatrix/LSPosed/releases/latest</string> | ||
| <string name="install_url" translatable="false">https://github.com/JingMatrix/Vector#install</string> |
There was a problem hiding this comment.
When the framework is not installed, HomeFragment opens install_url for the Install button, but this new Vector URL uses #install while the repo README section is headed ### Installation (README.md line 33), whose GitHub fragment is #installation. In that state the button lands at the top of the README instead of the installation instructions.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Fork-only review mirror of upstream PR JingMatrix#764. Pushing here to run Codex code review on the current head before updating the upstream PR.