Skip to content

[Draft] 2nd attempt at registering a external python module as shamro…#1278

Closed
tdavidcl wants to merge 19 commits into
Shamrock-code:mainfrom
tdavidcl:patch-2025-09-19-15-24
Closed

[Draft] 2nd attempt at registering a external python module as shamro…#1278
tdavidcl wants to merge 19 commits into
Shamrock-code:mainfrom
tdavidcl:patch-2025-09-19-15-24

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

…ck submodule

@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 3807163
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 1
New warnings : 17
Warnings count : 7768 → 7784 (0.2%)

Detailed changes :
+ src/pylib/shamrock/__init__.py:5: warning: Member IMPORT_LOG (variable) of namespace shamrock is not documented.
+ src/shambindings/include/shambindings/start_python.hpp:47: warning: The following parameters of shambindings::start_ipython(bool do_print, int argc, char *argv[]) are not documented:
+ src/shambindings/include/shambindings/start_python.hpp:47: warning: The following parameters of shambindings::start_ipython(bool do_print, int argc, char *argv[]) are not documented:
+ src/shambindings/include/shambindings/start_python.hpp:57: warning: The following parameters of shambindings::run_py_file(std::string file_path, bool do_print, int argc, char *argv[]) are not documented:
+ src/shambindings/include/shambindings/start_python.hpp:57: warning: The following parameters of shambindings::run_py_file(std::string file_path, bool do_print, int argc, char *argv[]) are not documented:
+ src/shambindings/src/start_python.cpp:115: warning: Member locate_pylib_path(bool do_print) (function) of namespace shambindings is not documented.
+ src/shambindings/src/start_python.cpp:92: warning: Member pylib_path_env_var (variable) of file start_python.cpp is not documented.
+ src/shambindings/src/start_python.cpp:96: warning: Member get_binary_path() (function) of namespace shambindings is not documented.

@tdavidcl

Copy link
Copy Markdown
Member Author

This PR is superseded by PR #1547.

@tdavidcl tdavidcl closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant