Skip to content

[Clang-tidy] Fix warning for uninitialized vars in fallbackReduction.hpp #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdavidcl merged 3 commits into from
Dec 14, 2025
Merged

[Clang-tidy] Fix warning for uninitialized vars in fallbackReduction.hpp #1423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0168edc
fix warning
Akos299 Dec 12, 2025
021dbab
Merge branch 'main' into features/clang-tidy-fix-2
tdavidcl Dec 12, 2025
8fe2f06
Merge branch 'main' into features/clang-tidy-fix-2
tdavidcl Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/shamalgs/include/shamalgs/details/reduction/fallbackReduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@

/**
* @file fallbackReduction.hpp
* @author Léodasce Sewanou (leodasce.sewanou@ens-lyon.fr)
* @author Timothée David--Cléris (tim.shamrock@proton.me)
* @brief
*
*/

#include "shambase/numeric_limits.hpp"
#include "shambackends/math.hpp"
#include "shambackends/sycl.hpp"

Expand All @@ -33,7 +35,7 @@ namespace shamalgs::reduction::details {

template<class T>
inline T _int_sum(sycl::queue &q, sycl::buffer<T> &buf1, u32 start_id, u32 end_id) {
T accum;
T accum = T{};

{
sycl::host_accessor acc{buf1, sycl::read_only};
Expand All @@ -52,7 +54,7 @@ namespace shamalgs::reduction::details {

template<class T>
inline T _int_min(sycl::queue &q, sycl::buffer<T> &buf1, u32 start_id, u32 end_id) {
T accum;
T accum = shambase::get_max<T>();

{
sycl::host_accessor acc{buf1, sycl::read_only};
Expand All @@ -71,7 +73,7 @@ namespace shamalgs::reduction::details {

template<class T>
inline T _int_max(sycl::queue &q, sycl::buffer<T> &buf1, u32 start_id, u32 end_id) {
T accum;
T accum = shambase::get_min<T>();

{
sycl::host_accessor acc{buf1, sycl::read_only};
Expand Down
Loading