Revert WIP GLM-5.1 commits from main#26
Merged
Merged
Conversation
added 4 commits
April 19, 2026 14:39
There was a problem hiding this comment.
Pull request overview
Reverts the unfinished GLM 5.1 (GLM MoE DSA) work that was accidentally merged into main, removing the model implementation and its factory registration.
Changes:
- Removes the
GLMMoeDSAmodel implementation file. - Removes the
glm_moe_dsaentry fromLLMModelFactoryregistry. - Updates integration test pattern matching for streamed
Generationchunks (currently introduces a compile issue).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Libraries/MLXLLM/Models/GLMMoeDSA.swift | Deletes the GLM MoE DSA model implementation as part of the revert. |
| Libraries/MLXLLM/LLMModelFactory.swift | Removes the glm_moe_dsa model type mapping from the registry. |
| Libraries/IntegrationTestHelpers/IntegrationTestHelpers.swift | Adjusts streaming Generation switch cases (needs correction to match current enum shape). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| switch generation { | ||
| case .chunk(let text, _): | ||
| case .chunk(let text): |
| for try await generation in stream { | ||
| switch generation { | ||
| case .chunk(let chunk, _): | ||
| case .chunk(let chunk): |
…: Int) API signature
solderzzc
pushed a commit
that referenced
this pull request
Apr 20, 2026
This reverts commit 50c3732.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting unfinished GLM 5.1 work that was accidentally merged into main.