Skip to content

[perf-improver] perf: eliminate intermediate dictionary and generator allocations in ValueSet constructor #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: support/3.x
Choose a base branch
from
Open

[perf-improver] perf: eliminate intermediate dictionary and generator allocations in ValueSet constructor #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/Examine.Core/ValueSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ public ValueSet(string id, string category, IDictionary<string, object> values)
/// <param name="itemType"></param>
/// <param name="values"></param>
public ValueSet(string id, string category, string itemType, IDictionary<string, object> values)
: this(id, category, itemType, values.ToDictionary(x => x.Key, x => Yield(x.Value)))
: this(id, category, itemType,
(IReadOnlyDictionary<string, IReadOnlyList<object>>)values.ToDictionary(
x => x.Key,
x => (IReadOnlyList<object>)new[] { x.Value }))
{
}

Expand Down Expand Up @@ -129,16 +132,6 @@ public object GetValue(string key)
return !Values.TryGetValue(key, out var values) ? null : values.Count > 0 ? values[0] : null;
}

/// <summary>
/// Helper method to return IEnumerable from a single
/// </summary>
/// <param name="i"></param>
/// <returns></returns>
private static IEnumerable<object> Yield(object i)
{
yield return i;
}

public ValueSet Clone() => new ValueSet(Id, Category, ItemType, Values);
}
}