Added the reconcilation worker to run for deploymenment - #41
Merged
Conversation
pope-h
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #39
Summary
I've completed the reconciliation worker concurrency safety implementation. Here's a summary:
Implementation Summary
Files Modified:
Key Changes:
processingPromisebefore scheduling next tick to prevent self-overlappg_try_advisory_lock) to ensure only one replica runs passes at a timefinallyblock to ensure cleanup even on errorsCI Results:
npm ci- passednpm run lint- passednpm run test:ci- passed (all reconciliation tests pass)npm run openapi:validate- passedTest Coverage:
The reconciliation worker is now safe to run in horizontally scaled deployments. The advisory lock ensures a single leader runs passes cluster-wide, and the intra-process guard prevents self-overlap.
Linked issue (recommended)
Example:
Closes #123closes #38
Changes
This section is required for CI PR validation.
Contract Upgrade Details (if applicable)
This section is required for CI PR validation if this is a contract upgrade.
Network
New Contract
C...sha256:...G...[link to transaction explorer]Upgrade Governance
Verification Steps
How to test
This section is required for CI PR validation.
Security Considerations
This section is required for CI PR validation.
Screenshots (if UI)
Include before/after screenshots for any UI changes. For new features, show different states (loading, error, success). For responsive changes, include mobile/tablet/desktop views.
Checklist
This section is required for CI PR validation.