feat(as/group): support agency name #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ShiChangkuo wants to merge 2 commits into master from enhance

Owner

ShiChangkuo commented Apr 11, 2023

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

Tests added/passed.
Documentation updated.
Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s

github-actions bot added the feature label

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions bot added the size/XL label

ShiChangkuo force-pushed the master branch 2 times, most recently from 62e1705 to 66f2410 Compare

April 11, 2023 11:15

ShiChangkuo closed this

ShiChangkuo reopened this

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from 66f2410 to cf12c80 Compare

April 12, 2023 02:25

ShiChangkuo closed this

ShiChangkuo reopened this

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from cf12c80 to 11236cc Compare

April 12, 2023 02:29

ShiChangkuo closed this

ShiChangkuo reopened this

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from 11236cc to bdc7fc4 Compare

April 12, 2023 02:41

ShiChangkuo closed this

ShiChangkuo reopened this

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions bot added the bugfix label

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the enhance branch from 0e5d2f9 to 2c9a45d Compare

April 25, 2023 11:12

github-actions bot added chore dependencies documentation labels

github-actions bot commented Apr 25, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from bdc7fc4 to d300387 Compare

May 15, 2023 11:33

ShiChangkuo changed the title ~~Enhance~~ feat(as/group): support agency name

github-actions bot removed the dependencies label

github-actions bot commented Aug 22, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the enhance branch from ab114a3 to 77a3d3e Compare

August 29, 2023 08:24

github-actions bot commented Aug 29, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from e83f4bd to cc83d7a Compare

September 11, 2023 08:57

ShiChangkuo force-pushed the enhance branch from 77a3d3e to ca222aa Compare

September 13, 2023 09:47

github-actions bot removed the documentation label

github-actions bot commented Sep 13, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

2 similar comments

github-actions bot commented Sep 13, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions bot commented Sep 15, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.


          chore(ecs): use ECS API instead of nova API for metadata management

e98da0b

ShiChangkuo force-pushed the enhance branch from aab26c8 to abc1c69 Compare

September 15, 2023 08:26

github-actions bot commented Sep 15, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.


          feat(ecs): support metadata param

87b66ab

ShiChangkuo force-pushed the enhance branch from abc1c69 to 87b66ab Compare

September 15, 2023 08:28

github-actions bot commented Sep 15, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ShiChangkuo force-pushed the master branch from 1efbfb7 to 545ff59 Compare

September 19, 2023 03:13

ShiChangkuo force-pushed the master branch from 4001fde to 04a1618 Compare

September 28, 2023 05:34

ShiChangkuo force-pushed the master branch 12 times, most recently from d4bdf32 to e41bef3 Compare

December 15, 2023 12:32

ShiChangkuo force-pushed the master branch from e41bef3 to 36b765a Compare

December 28, 2023 13:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix chore dependencies feature refactor safe to test size/XL