SST optimisation #743
SST optimisation #743
Conversation
olantwin
left a comment
olantwin
left a comment
There was a problem hiding this comment.
Some first impressions.
If we want to merge this eventually, MyGenerator definitely needs a sensible name.
macro/update_from_file.py
Outdated
There was a problem hiding this comment.
In addition to the problem of the config format, I don't like how this depends on being able to modify global state.
There was a problem hiding this comment.
Could you please tell more on what do you mean by global state. I've re-imlemented changing parameters using a flag, is it ok?
There was a problem hiding this comment.
I'd prefer functions without side effects, to not surprise users.
There was a problem hiding this comment.
Please make sure that the cmakelint and cmake-format pre-commit hooks run cleanly on this.
There was a problem hiding this comment.
Clean up the commented code, update comments etc. which were copy-pasted from the strawtubes
shipgen/CMakeLists.txt
Outdated
| ${CMAKE_SOURCE_DIR}/shipdata | ||
| ${CMAKE_SOURCE_DIR}/veto | ||
| ${genfit2_INCDIR} | ||
| ${TPYTHIA6_INCLUDE_DIR} |
There was a problem hiding this comment.
What does your PR have to do with Pythia6?
shipgen/NtupleGenerator.cxx
Outdated
| cout << "-E NtupleGenerator: Error opening the Signal file" << fileName << endl; | ||
| } | ||
| fTree = (TTree *)fInputFile->Get("ntuple"); | ||
| fTree = (TTree *)fInputFile->Get("pythia8-Geant4"); |
There was a problem hiding this comment.
example file for MyGenerator; to show a needed structure of the ttree
There was a problem hiding this comment.
Please remove it. You can put an example file on EOS, and maybe mention it in the documentation of the generator, but example ROOT files should not be tracked in git.
There was a problem hiding this comment.
What's the purpose of this file?
There was a problem hiding this comment.
It produces file with variables that are necessary for MyGenerator only.
So only vertex positions, momentum and pdg code stored in strawdetector
There was a problem hiding this comment.
I think this is not of sufficient general interest to include in the main framework.
|
Also, please fix the merge conflicts, so that we can run the automatic checks. |
| parser.add_argument("--SND", dest="SND", help="Activate SND.", action='store_true') | ||
| parser.add_argument("--noSND", dest="SND", help="Deactivate SND. NOOP, as it currently defaults to off.", action='store_false') | ||
| #parser.add_argument("--psdz", dest="psdz", help="Set Prestrawdetector Z position", required=False, default=2586., type=float) | ||
| parser.add_argument("--decouple", dest="decouple", help="Decoupling flag", required=False, default=False, action='store_true') |
There was a problem hiding this comment.
This needs a better name and help message
macro/run_simScript.py
Outdated
| ) | ||
| parser.add_argument("--SND", dest="SND", help="Activate SND.", action='store_true') | ||
| parser.add_argument("--noSND", dest="SND", help="Deactivate SND. NOOP, as it currently defaults to off.", action='store_false') | ||
| #parser.add_argument("--psdz", dest="psdz", help="Set Prestrawdetector Z position", required=False, default=2586., type=float) |
There was a problem hiding this comment.
Why is this commented out?
macro/run_simScript.py
Outdated
| ) | ||
|
|
||
| ship_geo.decouple = options.decouple | ||
| ship_geo.psd=2586.0 |
There was a problem hiding this comment.
This needs a better name and comments to explain what these are, especially if they are set at the top level!
|
@AnalitikGnid Any updates on this? Some responses to the various questions and comments would be appreciated as well. |
|
@AnalitikGnid Any updates? |
AnalitikGnid
force-pushed
the
sst-optimisation
branch
from
1bea498 to
20fb5d2
Compare
AnalitikGnid
force-pushed
the
sst-optimisation
branch
from
8a6e012 to
2ced8d1
Compare
2 participants
Useful tools for SST decoupling and optimisation that could be used further
Added:
prestrawdetector— a thin air plane that can be placed anywhere in the simulation to store events.MyGenerator— a new generator module that injects events from a custom input file