Skip to content

Conversation

@eduard322
Copy link
Contributor

Fix the outdated method of the extraction of layer_id and layer_type for MTC.

@eduard322 eduard322 requested a review from a team as a code owner December 1, 2025 13:59
Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GetLayerType no longer needed?

@eduard322
Copy link
Contributor Author

Is GetLayerType no longer needed?

replaced with GetStationType

Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use single quotes to make it easier to read these powers of 10?
It's intentional that the old layer type and new station type are not the same?

@eduard322
Copy link
Contributor Author

Could you use single quotes to make it easier to read these powers of 10? It's intentional that the old layer type and new station type are not the same?

okay

P.S. I saw GetLayerType in the test script, so I will revert the naming back to that to minimize changes ¯_(ツ)_/¯

@olantwin
Copy link
Contributor

olantwin commented Dec 1, 2025

Could you use single quotes to make it easier to read these powers of 10? It's intentional that the old layer type and new station type are not the same?

okay

P.S. I saw GetLayerType in the test script, so I will revert the naming back to that to minimize changes ¯_(ツ)_/¯

We can also update the test script. Whichever you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants