refactor: extract MeanMaterialBudget to standalone function #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @siilieva |
olantwin
force-pushed
the
refactor/extract-mean-material-budget
branch
from
9f905af to
44c2625
Compare
Extract duplicated MeanMaterialBudget implementations from MuDISGenerator
and GenieGenerator into a standalone function with proper ALICE attribution.
Changes:
- Add shipgen/MeanMaterialBudget.{h,cxx} with BSD-3-Clause licence
- Use complete GenieGenerator implementation (10 parameters vs 8)
- Remove duplicate implementations from MuDISGenerator and GenieGenerator
- Update all callers to use shipgen::MeanMaterialBudget
- Add to CMakeLists.txt build configuration
The standalone version includes:
- Full 10-parameter interface with interaction length (mparam[8]) and
maximum cross section (mparam[9]) required by FixedTargetGenerator
and Pythia8Generator
- Original ALICE attribution (Marian Ivanov, Andrea Dainese, Andrei Gheata)
- SHiP improvements by Anupama Reghunath and Thomas Ruf
- Improved error logging
olantwin
force-pushed
the
refactor/extract-mean-material-budget
branch
from
44c2625 to
ea42431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract duplicated MeanMaterialBudget implementations from MuDISGenerator and GenieGenerator into a standalone function with proper ALICE attribution.
Changes:
The standalone version includes: