Consolidate Trade fee fields: MakerFee + TakerFee → Fee (closes #70)#71
Open
Consolidate Trade fee fields: MakerFee + TakerFee → Fee (closes #70)#71
Conversation
Maker fee is always 0; only takers are charged. The split-field naming implied a per-role rate model that doesn't exist — each order signs a single feeRateBps. Replace both fields with Fee int64 across domain, migration, repository, schema doc, and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MakerFee int64+TakerFee int64onTradewith a singleFee int64— maker fee is always 0, only takers are charged000002_create_trades.up.sql,pg_repository.goINSERT (10 params → 9),docs/schema.sql, and both test filesTest Plan
go build ./...— passesmake lint— passesmake test-integrationwith stack running to verifySaveTradeand affiliate repo tests against the updated schema