CI: Remove the molecule action usage from pull-request-management workflow

.github/check-git-status.sh

@@ -0,0 +1,47 @@
+#!/bin/bash
+#
+# Purpose: Molecule runner for github-action
+# Author: @titom73
+# Date: 2020-12-16
+# Version: 1.1
+# License: APACHE
+# --------------------------------------
+
+echo "Script running from ${PWD}"
+
+# Set default values
+INPUT_CHECK_GIT="${INPUT_CHECK_GIT:-true}"
+INPUT_CHECK_GIT_ENFORCED="${INPUT_CHECK_GIT_ENFORCED:-true}"
+
+if [ ${INPUT_CHECK_GIT} = "true" ]; then
+    git config core.fileMode false
+    echo "  * Run Git Verifier because CHECK_GIT is set to ${INPUT_CHECK_GIT}"
+    # if git diff-index --quiet HEAD --; then
+    GIT_STATUS="$(git status --porcelain)"
+    if  [ "$?" -ne "0" ]; then
+        echo "'git status --porcelain' failed to run - something is wrong"
+        exit 1
+    fi
+    if [ -n "$GIT_STATUS" ]; then
+        # Some changes
+        echo 'Some changes'
+        echo '------------'
+        git --no-pager status --short
+        echo ''
+        echo 'Diffs are:'
+        echo '------------'
+        git --no-pager diff
+        if [ ${INPUT_CHECK_GIT_ENFORCED} = "true" ]; then
+            exit 1
+        else
+            exit 0
+        fi
+    else
+        # No Changes
+        echo '    - No change found after running Molecule'
+        exit 0
+    fi
+    exit 0
+else
+    echo "  * Git verifier skipped as not set to true"
+fi

.github/requirements-ci-dev.txt

@@ -1,3 +1,5 @@
 # Installing PyAVD from source.
 # The package path below is relative to the repo root and will only work if the pip install is executed from there.
 ./python-avd[ansible-collection]
+molecule>=6.0
+molecule-plugins[docker]>=23.4.0

.github/workflows/pull-request-management.yml

@@ -140,7 +140,7 @@ jobs:
           - "eos_cli_config_gen_deprecated_vars"
           - "eos_cli_config_gen_negative_unit_tests"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         # Also test minimum ansible version for one scenario.
         include:
           - avd_scenario: "eos_cli_config_gen"
@@ -149,17 +149,14 @@ jobs:
     if: needs.file-changes.outputs.config_gen == 'true'
     steps:
       - uses: actions/checkout@v4
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: "ansible_collections/arista/avd"
-          molecule_command: "test"
-          molecule_args: "--scenario-name ${{ matrix.avd_scenario }}"
-          pip_file: .github/requirements-ci-dev.txt
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
       # - uses: actions/upload-artifact@v4
       #   with:
       #     name: molecule-${{ matrix.avd_scenario }}-artifacts
@@ -175,22 +172,19 @@ jobs:
       fail-fast: true
       matrix:
         avd_scenario: ["dhcp_configuration", "dhcp_provisioning"]
-        ansible_version: ["ansible-core<2.19.0 --upgrade"]
+        ansible_version: ["ansible-core<2.19.0"]
     needs: [file-changes]
     if: needs.file-changes.outputs.dhcp == 'true'
     steps:
       - uses: actions/checkout@v4
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: "ansible_collections/arista/avd"
-          molecule_command: "test"
-          molecule_args: "--scenario-name ${{ matrix.avd_scenario }}"
-          pip_file: .github/requirements-ci-dev.txt
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
       # - uses: actions/upload-artifact@v4
       #   with:
       #     name: molecule-${{ matrix.avd_scenario }}-artifacts
@@ -225,19 +219,19 @@ jobs:
           - "example-cv-pathfinder"
         ansible_version:
           # Testing all scenario with 2.16.x, due to bug with in 2.17.0 with and the way we test eos_designs_negative_unit_tests https://github.com/ansible/ansible/issues/83292
-          - "ansible-core>=2.16.0,<2.17.0 --upgrade"
+          - "ansible-core>=2.16.0,<2.17.0"
         pip_requirements:
           - ".github/requirements-ci-dev.txt"
         # Also test minimum ansible version for one scenario.
         include:
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core==2.16.0 --upgrade"
+            ansible_version: "ansible-core==2.16.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core<2.18.0 --upgrade"
+            ansible_version: "ansible-core<2.18.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core<2.19.0 --upgrade"
+            ansible_version: "ansible-core<2.19.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
     needs: [file-changes]
     if: needs.file-changes.outputs.eos_design == 'true' || needs.file-changes.outputs.config_gen == 'true'
@@ -249,17 +243,14 @@ jobs:
           uv pip compile .github/requirements-ci-dev.txt --resolution=lowest-direct > ${{ matrix.pip_requirements }}
           cat ${{ matrix.pip_requirements }}
         if: matrix.pip_requirements == 'tmp-requirements-minimum.txt'
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: "ansible_collections/arista/avd"
-          molecule_command: "test"
-          molecule_args: "--scenario-name ${{ matrix.avd_scenario }}"
-          pip_file: ${{ matrix.pip_requirements }}
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
       # - uses: actions/upload-artifact@v4
       #   with:
       #     name: molecule-${{ matrix.avd_scenario }}-artifacts
@@ -276,7 +267,7 @@ jobs:
         avd_scenario:
           - "eos_config_deploy_cvp"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         include:
           - avd_scenario: "eos_config_deploy_cvp"
             ansible_version: "ansible-core==2.16.0"
@@ -285,17 +276,14 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: "ansible_collections/arista/avd"
-          molecule_command: "test"
-          molecule_args: "--scenario-name ${{ matrix.avd_scenario }}"
-          pip_file: .github/requirements-ci-dev.txt
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
       # - uses: actions/upload-artifact@v4
       #   with:
       #     name: molecule-${{ matrix.avd_scenario }}-artifacts
@@ -313,25 +301,22 @@ jobs:
         avd_scenario:
           - 'anta_runner'
         ansible_version:
-          - 'ansible-core<2.19.0 --upgrade'
+          - 'ansible-core<2.19.0'
         include:
           - avd_scenario: 'anta_runner'
             ansible_version: 'ansible-core==2.16.0'
     needs: [ file-changes ]
     if: needs.file-changes.outputs.eos_design == 'true' || needs.file-changes.outputs.anta_runner == 'true'
     steps:
       - uses: actions/checkout@v4
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: 'ansible_collections/arista/avd'
-          molecule_command: 'test'
-          molecule_args: '--scenario-name ${{ matrix.avd_scenario }}'
-          pip_file: .github/requirements-ci-dev.txt
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
 
   # ----------------------------------- #
   # EOS Validate State MOLECULE
@@ -345,25 +330,22 @@ jobs:
         avd_scenario:
           - "eos_validate_state"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         include:
           - avd_scenario: "eos_validate_state"
             ansible_version: "ansible-core==2.16.0"
     needs: [file-changes]
     if: needs.file-changes.outputs.eos_design == 'true' || needs.file-changes.outputs.validate_state == 'true'
     steps:
       - uses: actions/checkout@v4
-      - name: Run molecule action
-        uses: arista-netdevops-community/[email protected]
-        with:
-          molecule_parentdir: "ansible_collections/arista/avd"
-          molecule_command: "test"
-          molecule_args: "--scenario-name ${{ matrix.avd_scenario }}"
-          pip_file: .github/requirements-ci-dev.txt
-          galaxy_file: "ansible_collections/arista/avd/collections.yml"
-          ansible: ${{ matrix.ansible_version }}
-          check_git: true
-          check_git_enforced: true
+      - name: Run molecule test
+        run: |
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
+          cd ansible_collections/arista/avd
+          molecule test --scenario-name ${{ matrix.avd_scenario }}
+      - name: Check GIT status
+        run: |
+          sh .github/check-git-status.sh
 
   # ----------------------------------- #
   # Ansible tests