Skip to content

Conversation

@rastreus
Copy link

@rastreus rastreus commented Feb 8, 2022

Added full type annotations for Blob and URL.createObjectURL

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (fake build or .\build.cmd) on local branch was successful

fake build failed during the Restore task with (Unsupported log file format. Latest supported version is 9, the log file has version 14.), but the library successfully compiles with Fable 3 now.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Compilation fails with the following error:

Started Fable compilation...
Fable compilation finished in 9293ms                                                

./fable_modules/Feliz.UseWorker.0.5.2/Worker.fs(122,18): (122,24) error FSHARP: The type 'BinaryType' does not define the field, constructor or member 'Create'. (code 39)
./fable_modules/Feliz.UseWorker.0.5.2/Worker.fs(123,24): (123,30) error FSHARP: The type 'BinaryType' does not define the field, constructor or member 'Create'. (code 39)
Compilation failed
error Command failed with exit code 1.

What is the new behavior?

Compilation succeeds.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Added full type annotations for Blob and URL.createObjectURL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant