Skip to content

Add title to component iframes #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add title to component iframes #722

wants to merge 1 commit into from

Conversation

spencercanner
Copy link

@spencercanner spencercanner commented Sep 10, 2020

  • Add new text options to enable configuration of iframe titles
    • A new text option was not added to the cart since we can use the title text option
  • Add new getter to the component class to return the iframe title from the text options
    • The cart class overrides this getter to return the title from the text options
  • Update the generic view class to pass through the component's iframeTitle when creating the iframe
  • Update the iframe class to add a title attribute to the element if it is provided in the config

To 🎩 :

  • Create a buy button where all component are iframes (product, productSet, modal, modalProduct, toggle, cart)
  • Navigate a screen reader through the page
  • Verify that all iframes are announced with their respective titles
    • Note the cart toggle iframe isn't announced because it is inside a div with an aria-label, but the title can be seen by inspecting the element.
  • Safari - Mac - VoiceOver
  • Firefox - Windows - NVDA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant