Skip to content

Change product title from h1 to h2 #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencercanner
Copy link

@spencercanner spencercanner commented Nov 9, 2020

  • Change product title element from h1 to h2
  • Although we're not aware of the context in which buy buttons are embedded, semantically the product title should most likely not be an h1
    • This can always be configured by the consumer by customizing the product title template
  • In the case of collections, we end up having a bunch of h1 elements which can make it difficult to parse the page when using a screen reader
  • This change also applies to the modal product title

To 🎩 :

  • Create a buy button with a button destination of modal
  • Navigate a virtual cursor to the product title
  • Verify that it is announced as a heading level 2
  • Open the product details modal
  • Navigate a virtual cursor to the modal product title
  • Verify that it is announced as a heading level 2
  • Sanity check that styling is unaffected by the tag change
  • Chrome, Firefox, Safari (Sanity check)
  • Safari/Mac VoiceOver
  • Firefox/Windows NVDA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant