removes pointer to external marketing_assets #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpprieto
approved these changes
Apr 11, 2025
juanpprieto
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/Shopify/ms-marketing-fed/issues/5178
The marketing_assets package is not maintained and will be deprecated. As part of this effort, use-cases were identified where it is still being used. This PR swaps the external link to the marketing_assets css with a static css file of the current marketing_assets css.
The other use of marketing_assets in this package are not build or live site dependencies, so they can be left as-is; as long as they are never updated (being that this repo/package is old as well that seems like a safe assumption).