Add support for checkout.submit #503
Conversation
Wire up the CheckoutSubmitStartEvent to the SwiftUI modifier pattern,
allowing SwiftUI apps to handle checkout submit events via:
.onSubmitStart { event in
// Handle submit start
event.respondWith(payload: response)
}
Adds testOnSubmitStart to verify the SwiftUI modifier correctly wires up the CheckoutSubmitStartEvent to the delegate wrapper.
markmur
force-pushed
the
prototype/onSubmitStart-swiftui
branch
from
51af86c to
4f32f72
Compare
markmur
force-pushed
the
prototype/checkout.submit
branch
from
56d6680 to
10fa83c
Compare
| // MARK: - Encodable Conformance | ||
|
|
||
| extension CheckoutSubmitRequest { | ||
| public func encode(to encoder: Encoder) throws { |
There was a problem hiding this comment.
Could this be declared in the OutboundRPCRequest extension?
Using the associatedType ResponsePayload generic you should have access to the Codable
|
|
||
| // Cancel any pending outbound requests to prevent continuation leaks | ||
| Task { [pendingRequests] in | ||
| await pendingRequests.cancelAll() |
There was a problem hiding this comment.
Wonder if this should also be cleared if URL changes? I think load could be called multiple times on the same Webview
| // Get the raw response data from the pending request | ||
| let responseData: Data = try await withCheckedThrowingContinuation { continuation in | ||
| Task { | ||
| await pendingRequests.register(id: request.id, continuation: continuation) |
There was a problem hiding this comment.
Does this have a race condition with CheckoutBridge.sendRequest?
Could all of this go in an async context?
|
|
||
| Task { | ||
| do { | ||
| let responseData = try JSONEncoder().encode(response) |
There was a problem hiding this comment.
A back and forth happening here on these response types
userContentController( _: WKUserContentController, didReceive message: WKScriptMessage ) Does the following
- Calls CheckoutBridge.decode
- Calls
handleBridgeEvent
So the entry point for these responses is decode to envelope, then encode back to data, and we complete the pendingRequests withData
Possible optimisation opportunity
|
I suppose we're not exposing this in the imperative API. Which feels like it's probably OK? |
|
Definitely on the right track |
markmur
force-pushed
the
prototype/onSubmitStart-swiftui
branch
from
ca6ed8f to
f492e4a
Compare
3 participants
What changes are you making?
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.