Remove timer faking from functionWatcher tests

[lopert]

WHY are these changes introduced?

Part of https://github.com/Shopify/shopify-functions/issues/481

This test was reported as flakey, so this attempts to fix it by removing the unnecessary timer faking.

WHAT is this pull request doing?

Swaps out our timer faking with a more straightforward waitFor that just checks the last returned result from our hook function until it matches what we expect.

I used waitFor from cli-kit's testing/ui, and had to add it to the public export.
I figured this was fine, but if it's not I could also copy the code from it into our tests more directly.

I also looked at usePollAppLogsTest where we used a similar approach, but I chose to keep it as is over there since that test has a lot to do with timing, retries, and enqueued timers. It makes sense over there.

How to test your changes?

p vitest function/ui

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.46% (+0.01% 🔼)	9012/11943
🟡	Branches	70.65% (+0.02% 🔼)	4396/6222
🟡	Functions	75.26%	2364/3141
🟡	Lines	75.98% (+0.01% 🔼)	8513/11205

Test suite run success

2035 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 583ec94

[isaacroldan]

Vitest has its own vi.waitFor (docs) that waits until a condition is true, you can also add a expect inside it. I think is a better solution for your case and you don't need to export cli-kit's implementation.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/testing/ui.d.ts

@@ -1 +1 @@
-export { getLastFrameAfterUnmount, render, Stdin, waitForInputsToBeReady, waitForContent, sendInputAndWait, sendInputAndWaitForChange, sendInputAndWaitForContent, } from '../../../private/node/testing/ui.js';
\ No newline at end of file
+export { getLastFrameAfterUnmount, render, Stdin, waitFor, waitForInputsToBeReady, waitForContent, sendInputAndWait, sendInputAndWaitForChange, sendInputAndWaitForContent, } from '../../../private/node/testing/ui.js';
\ No newline at end of file

[github-actions]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

[lopert]

Still relevant, waiting on https://github.com/Shopify/develop-app-inner-loop/issues/2552